Skip to content

Commit

Permalink
Enable API review approval check for Java spring packages (Azure#15305)
Browse files Browse the repository at this point in the history
Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
  • Loading branch information
2 people authored and vindicatesociety committed Sep 18, 2021
1 parent c8b0457 commit 4247944
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion eng/common/scripts/Create-APIReview.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,9 @@ if ($packages)
else
{
# Return error code if status code is 201 for new data plane package
if ($pkgInfo.SdkType -eq "client" -and $pkgInfo.IsNewSdk)
# Temporarily enable API review for spring SDK types. Ideally this should be done be using 'IsReviewRequired' method in language side
# to override default check of SDK type client
if (($pkgInfo.SdkType -eq "client" -or $pkgInfo.SdkType -eq "spring") -and $pkgInfo.IsNewSdk)
{
if ($respCode -eq '201')
{
Expand Down

0 comments on commit 4247944

Please sign in to comment.