Add ability to customize what are extractable files #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n1ru4l
commented
Jul 24, 2019
# Conflicts: # readme.md # src/test.mjs
|
That's a useful PR. It would decouple the module from the ReactNative. Nice. |
My intended use-case was in Node.js environments. @jaydenseric Sorry for bothering you, but this change is floating around for a while now. 😅Is there anything blocking this PR from getting merged? |
|
@n1ru4l sorry for the delay, I have just returned from a holiday and am recovering from a cold but I hope to dig into it this week :) |
|
Any news? |
|
@jaydenseric sorry to bother you. When this PR will be merged? Do you need any help? |
3 tasks
# Conflicts: # src/extractFiles.mjs # src/index.mjs # src/test.mjs
jaydenseric
changed the title
|
@n1ru4l thanks for kicking this off 🙌 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #10
isFileValuefunction.isFileValuefunctionisFileValuetoextractFilesfunction (default value is the exportedisfileValuefunction)isFileValueoption is working correctly@jaydenseric Could you please provide some feedback? Especially regarding the jsdoc stuff. Is adding a new typedef for
IsFileValueFunctioncorrect?