Skip to content

Commit

Permalink
Remove deprecated remote compaction apis
Browse files Browse the repository at this point in the history
  • Loading branch information
jaykorean committed Dec 5, 2024
1 parent 2a9a8da commit 58d7ea4
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 19 deletions.
19 changes: 0 additions & 19 deletions include/rocksdb/options.h
Original file line number Diff line number Diff line change
Expand Up @@ -531,25 +531,6 @@ class CompactionService : public Customizable {
virtual void OnInstallation(const std::string& /*scheduled_job_id*/,
CompactionServiceJobStatus /*status*/) {}

// Deprecated. Please implement Schedule() and Wait() API to handle remote
// compaction

// Start the remote compaction with `compaction_service_input`, which can be
// passed to `DB::OpenAndCompact()` on the remote side. `info` provides the
// information the user might want to know, which includes `job_id`.
virtual CompactionServiceJobStatus StartV2(
const CompactionServiceJobInfo& /*info*/,
const std::string& /*compaction_service_input*/) {
return CompactionServiceJobStatus::kUseLocal;
}

// Wait for remote compaction to finish.
virtual CompactionServiceJobStatus WaitForCompleteV2(
const CompactionServiceJobInfo& /*info*/,
std::string* /*compaction_service_result*/) {
return CompactionServiceJobStatus::kUseLocal;
}

~CompactionService() override = default;
};

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Deprecated Remote Compaction APIs (StartV2, WaitForCompleteV2) are completely removed from the codebase

0 comments on commit 58d7ea4

Please sign in to comment.