Fix issues found by Psalm and Phan

jaylinski · May 22, 2021 · 8ce7e4d · 8ce7e4d
1 parent 4584d26
commit 8ce7e4d
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/src/XmlTv.php b/src/XmlTv.php
@@ -70,9 +70,7 @@ private static function buildDocument(DOMNode $domNode, XmlElement $xmlElement):
  self::buildDocument($node, $child);
  }
  } else {
- if (!is_null($xmlElement->getValue())) {
- $node->textContent = $xmlElement->getValue();
- }
+ $node->textContent = $xmlElement->getValue() ?? '';
  }
  }
 
@@ -111,6 +109,6 @@ private static function isEmptyElement(XmlElement $xmlElement): bool
  empty($xmlElement->getValue()) &&
  !$xmlElement->hasChildren() &&
  !$xmlElement->hasAttributes() &&
- !in_array($xmlElement->getName(), self::EMPTY_ELEMENTS);
+ !in_array($xmlElement->getName(), self::EMPTY_ELEMENTS, $strict = true);
  }
 }