Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues reported by PHPStan #28

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Fix issues reported by PHPStan #28

merged 1 commit into from
Nov 25, 2020

Conversation

jaylinski
Copy link
Owner

Fixed all PHPStan issues up to level 4 and added PHPStan to
CI scripts.

Added a new test-case to test a basic setup. This also tests the
removal of empty elements.

Fixes #27

@jaylinski jaylinski self-assigned this Nov 25, 2020
@codecov
Copy link

codecov bot commented Nov 25, 2020

Codecov Report

Merging #28 (9b4a729) into master (b90c0da) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##              master       #28   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       130       133    +3     
===========================================
  Files             33        33           
  Lines            378       376    -2     
===========================================
- Hits             378       376    -2     
Impacted Files Coverage Δ Complexity Δ
src/Tv.php 100.00% <ø> (ø) 6.00 <0.00> (ø)
src/Tv/Channel.php 100.00% <ø> (ø) 8.00 <0.00> (ø)
src/Tv/Elements/Audio.php 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
src/Tv/Elements/Subtitles.php 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
src/Tv/Elements/Video.php 100.00% <100.00%> (ø) 2.00 <0.00> (ø)
src/Tv/Programme.php 100.00% <100.00%> (ø) 30.00 <0.00> (ø)
src/XmlElement.php 100.00% <100.00%> (ø) 18.00 <11.00> (+2.00)
src/XmlTv.php 100.00% <100.00%> (ø) 17.00 <7.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90c0da...9b4a729. Read the comment docs.

Fixed all PHPStan issues up to level 4 and added PHPStan to
CI scripts.
Fixed an issue reported by PhpStorm.

Added a new test-case to test a basic setup. This also tests the
removal of empty elements.

Fixes #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

small fix would be nice
1 participant