Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPR: don't autofill when more than one commit exists #154

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

jaymzh
Copy link
Owner

@jaymzh jaymzh commented Mar 21, 2024

  • If > 1 commit exists, don't pass in --fill
  • Add a new option to allow people to opt-out of --fill in all cases
  • Tell people when we are autofilling

Closes #152

Signed-off-by: Phil Dibowitz phil@ipom.com

@jaymzh jaymzh force-pushed the spr-fix branch 2 times, most recently from 9bca2a7 to a1e2792 Compare March 21, 2024 19:02
* If > 1 commit exists, don't pass in --fill
* Add a new option to allow people to opt-out of --fill in all cases
* Tell people when we are autofilling

Closes #152

Signed-off-by: Phil Dibowitz <phil@ipom.com>
@jaymzh jaymzh merged commit ab5ca27 into main Mar 21, 2024
7 checks passed
@jaymzh jaymzh deleted the spr-fix branch March 21, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFE] don't pass --fill to pr create if there's more than one commit on the branch
1 participant