-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly detect iSCSI disks #297
Comments
avishayt
added a commit
to avishayt/ghw
that referenced
this issue
Jan 31, 2022
Merged
avishayt
added a commit
to avishayt/ghw
that referenced
this issue
Mar 15, 2022
avishayt
added a commit
to avishayt/ghw
that referenced
this issue
Mar 15, 2022
avishayt
added a commit
to avishayt/ghw
that referenced
this issue
Mar 15, 2022
Fixes: jaypipes#297 Signed-off-by: Avishay Traeger <avishay@gmail.com>
avishayt
added a commit
to avishayt/ghw
that referenced
this issue
Mar 15, 2022
Fixes: jaypipes#297 Signed-off-by: Avishay Traeger <avishay@redhat.com>
@avishayt Sorry to get to this so late, but iSCSI is not the drive type, AFAIK. SCSI is the storage controller interface, and all iSCSI drives should appear as HDD drive type and SCSI storage controller... is there a reason we needed a separate iSCSI drive type? @fromanirh I am considering reverting this PR... |
yes, that's actually a good point I should have considered :\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
iSCSI block devices are currently detected as "HDD" - it would be beneficial to detect them as "iSCSI".
The text was updated successfully, but these errors were encountered: