Add ability to override protocol #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
node12 performance boost
Cognigy npm publish
fix backpressure
add tslib to dependencies
remove examples
add odata nextlink
add missing devDependency extend
remove unused devDependencies
Bug/fix extra quote
change test port
Change the npm scope to cognigy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The module currently cleverly uses the value of req.secure to determine whether to use http or https for the OData records. However, if your OData service is running behind a loadbalancer that terminates TLS, then http will always be used. You therefore currently have to have port 80 open to use the OData service in Excel or Power BI, which is not allowed in certain companies for security reasons.
This PR therefore adds the ability to override the protocol by passing in the value of the protocol when creating the server, thus allowing the OData records to be served with https, even if TLS was previously terminated.
I hope the extra protocol options doesn't break the structure of your code. If you want to have this fix done differently to be able to merge it, then let me know or feel free to change the code.