Custom jsonPath to work with newer versions of coverage #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The dist folder needs to be re-generated for this PR to be complete. Is this something anyone can help with? |
reubenjohn
commented
Nov 25, 2023
| @@ -85,7 +85,7 @@ it('test badge case - custom label', async () => { | |||
| expect(str.indexOf(`<text x="50" y="138" textLength="715">${customLabel}</text>`) > 0).toBeTruthy(); | |||
| }); | |||
|
|
|||
| it('test badge case - custom icon', async () => { | |||
| it.skip('test badge case - custom icon', async () => { | |||
There was a problem hiding this comment.
I'm not sure why this is failing, can anyone help debug this?
There was a problem hiding this comment.
@reubenjohn I fixed it. thanks
I combined my research. It's not good to test |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 25, 2023
…29) * Support for custom json paths to coverage % * Update README.md * Passthrough jsonPath argument * Temporary unique action name * Register jsonPath action input * Fix compilation * Fixed compilation * Updated jsonPath default value * Better error handling * Critical jsonPath bug fix * Updated test cases * Skip test 1a2deef
jaywcjlove
added a commit
that referenced
this pull request
Nov 25, 2023
jaywcjlove
added a commit
that referenced
this pull request
Nov 25, 2023
jaywcjlove
added a commit
that referenced
this pull request
Nov 25, 2023
|
@reubenjohn I merged it, and now it looks fine. Can you provide some documentation examples for the newly provided 'jsonPath' parameter? @reubenjohn thx! |
jaywcjlove
added a commit
that referenced
this pull request
Nov 25, 2023
jaywcjlove
reviewed
Nov 25, 2023
| @@ -1,4 +1,4 @@ | |||
| name: 'Create Coverage Badges' | |||
| name: 'Create Custom Coverage Badges' | |||
| author: 'Kenny Wong' | |||
jaywcjlove
added a commit
that referenced
this pull request
Nov 25, 2023
|
@jaywcjlove thanks for the prompt response! I'd be happy to add some documentation this weekend. |
|
@reubenjohn thank you. |
jaywcjlove
added a commit
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the newer versions of coverage (eg. 7.3.2,), the JSON format has changed.
Eg:
Which results in the following error:
The proposed solution is to introduce a new argument called jsonPath which allows you to specify the path to the percentage field in the JSON file you would like to use in the badge.