-
-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new search function #117
base: master
Are you sure you want to change the base?
new search function #117
Conversation
✅ Deploy Preview for githubrank ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@372798735 Thank you for your PR, but I think the browser's built-in search function is sufficient. |
I think adding this search function is a little more detailed relative to the browser search
前进的蜗牛
***@***.***
…------------------ 原始邮件 ------------------
发件人: "jaywcjlove/github-rank" ***@***.***>;
发送时间: 2024年4月19日(星期五) 上午10:09
***@***.***>;
***@***.******@***.***>;
主题: Re: [jaywcjlove/github-rank] new search function (PR #117)
image.png (view on web)
@372798735 Thank you for your PR, but I think the browser's built-in search function is sufficient.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
README-zh.md
Outdated
## 克隆项目 | ||
|
||
```bash | ||
git clone https://github.com/372798735/github-rank-fork.git | ||
``` | ||
```bash | ||
cd github-rank-fork | ||
|
||
npm install | ||
``` | ||
run | ||
```bash | ||
npm run start | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 91 to 114 in 303bad1
## 开发 | |
```bash | |
$ git clone https://github.com/jaywcjlove/github-rank.git | |
$ cd github-rank | |
$ npm install # 安装依赖 | |
$ npm run build # 编译输出脚本 | |
``` | |
获取数据 | |
```bash | |
$ npm run get:trending # 获取 trending 数据 | |
$ npm run get:repos # 获取 repos 数据 | |
$ npm run get:users # 获取 users 数据 | |
$ npm run get:users:china # 获取 users(china) 数据 | |
``` | |
生成 HTML 页面 | |
```bash | |
$ npm run start | |
``` | |
The content is redundant with the following.
README.md
Outdated
run | ||
```bash | ||
npm run start | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lines 91 to 114 in 303bad1
## 开发 | |
```bash | |
$ git clone https://github.com/jaywcjlove/github-rank.git | |
$ cd github-rank | |
$ npm install # 安装依赖 | |
$ npm run build # 编译输出脚本 | |
``` | |
获取数据 | |
```bash | |
$ npm run get:trending # 获取 trending 数据 | |
$ npm run get:repos # 获取 repos 数据 | |
$ npm run get:users # 获取 users 数据 | |
$ npm run get:users:china # 获取 users(china) 数据 | |
``` | |
生成 HTML 页面 | |
```bash | |
$ npm run start | |
``` | |
The content is redundant with the following.
@372798735 I think calling this feature 'filtering' is appropriate. I believe we can merge it, but there's a bug in the functionality: the sorting feature for 'followers' and 'following' is not working. |
Okay, I'll fix it tonight |
@372798735 I tested it and the clicks still don't sort. |
|
@372798735 I tested locally, but the sorting still doesn't work. |
No description provided.