Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right command does not fires on macOS #92

Open
KirillSuhodolov opened this issue Jun 24, 2019 · 15 comments
Open

Right command does not fires on macOS #92

KirillSuhodolov opened this issue Jun 24, 2019 · 15 comments

Comments

@KirillSuhodolov
Copy link

hotkeys('ctrl+r, command+r', function() {
  alert('stopped reload!');
  return false;
});

from example

left command fires, but right not, on macOS

@jaywcjlove
Copy link
Owner

@KirillSuhodolov https://codepen.io/jaywcjlove/pen/xorRvW

hotkeys('ctrl+r, command+r', function(event,handler) {
  event.preventDefault();
  console.log('handle', handler.key,  event)
});

@bichotll
Copy link

bichotll commented Jul 3, 2019

I can confirm that. (Right) command+r does not work for me either.

@KirillSuhodolov
Copy link
Author

example not working too

@jaywcjlove
Copy link
Owner

@KirillSuhodolov I tested no problem.
image

@VikasShashidhar
Copy link

VikasShashidhar commented Jul 25, 2019

This does not work for me either - https://jsfiddle.net/vikasshashidhar/qcxd53m1/1/. The right option key works though.

@VikasShashidhar
Copy link

@jaywcjlove Any updates on this please?

@jaywcjlove
Copy link
Owner

image

- hotkeys("option+k,cmd+k", function(event, handler) {
+ hotkeys("option+k,command+k", function(event, handler) {
  console.log('handler:', handler.shortcut);
});

@VikasShashidhar I tested no problem, I don't know if it is a browser version issue.

@VikasShashidhar
Copy link

@jaywcjlove It's weird! I am able to make this work on Firefox but not on Chrome or Safari. What version of Chrome are you trying this on?

Also, it's only the right cmd that doesn't work. The right option works just fine.

Right Command Bug

@jaywcjlove
Copy link
Owner

@VikasShashidhar Google Chrome v75.0.3770.142

@VikasShashidhar
Copy link

@jaywcjlove I am using the exact same version and running into this issue. I am not sure how else I can help you repro this. Any suggestions?

@jaywcjlove
Copy link
Owner

@VikasShashidhar Can I run your example?

@VikasShashidhar
Copy link

Of course. Please go ahead. You can use the fiddle that I shared to do that.

@felixreichle
Copy link

Had the same issue, moved line 193-195 in main.js to line 187. This fixed it for me, not sure if it's breaking something else though.

@jaywcjlove
Copy link
Owner

jaywcjlove added a commit that referenced this issue Aug 9, 2019
@jaywcjlove
Copy link
Owner

@KirillSuhodolov @VikasShashidhar @felixreichle
I don't know if I can solve the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants