Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more detail to the README #103

Merged
merged 1 commit into from
Aug 21, 2019

Conversation

yakov116
Copy link
Contributor

@jaywcjlove I am still in middle and have some questions. Will follow up later

@codecov-io
Copy link

codecov-io commented Aug 21, 2019

Codecov Report

Merging #103 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #103   +/-   ##
======================================
  Coverage    83.9%   83.9%           
======================================
  Files           1       1           
  Lines         174     174           
======================================
  Hits          146     146           
  Misses         28      28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8baca96...603ac40. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 171

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.942%

Totals Coverage Status
Change from base Build 170: 0.0%
Covered Lines: 146
Relevant Lines: 174

💛 - Coveralls

@jaywcjlove jaywcjlove marked this pull request as ready for review August 21, 2019 14:20
@jaywcjlove jaywcjlove merged commit 2119e8a into jaywcjlove:master Aug 21, 2019
@jaywcjlove
Copy link
Owner

@yakov116 thx! 👍

jaywcjlove added a commit that referenced this pull request Aug 21, 2019
@yakov116
Copy link
Contributor Author

@jaywcjlove I had some questions should I open a new PR?

@jaywcjlove
Copy link
Owner

@yakov116 You can open a new PR and you need to merge the upstream code. Otherwise there will be conflicts.

You can refer to the link below.

https://github.com/jaywcjlove/git-tips/tree/6c5f566d98b3fe11c88789975867eef1c319a2db#%E5%90%8C%E6%AD%A5fork%E7%9A%84%E4%B8%8A%E6%B8%B8%E4%BB%93%E5%BA%93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants