Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/bind plus #105

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Feat/bind plus #105

merged 1 commit into from
Aug 23, 2019

Conversation

yyjjqq94
Copy link
Contributor

@yyjjqq94 yyjjqq94 commented Aug 23, 2019

support like:
hotkeys('ctrl-y, ctrl-a', {splitKey: '-'}, function(e){
console.log('you press bind keys')
})

Close #104

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #105 into master will increase coverage by 2.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #105      +/-   ##
=========================================
+ Coverage    83.9%   86.2%   +2.29%     
=========================================
  Files           1       1              
  Lines         174     174              
=========================================
+ Hits          146     150       +4     
+ Misses         28      24       -4
Impacted Files Coverage Δ
dist/hotkeys.js 86.2% <0%> (+2.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 753f581...9ea8ad1. Read the comment docs.

@coveralls
Copy link

coveralls commented Aug 23, 2019

Pull Request Test Coverage Report for Build 175

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.4%) to 73.298%

Totals Coverage Status
Change from base Build 173: 2.4%
Covered Lines: 150
Relevant Lines: 174

💛 - Coveralls

@jaywcjlove jaywcjlove merged commit 2616b67 into jaywcjlove:master Aug 23, 2019
@jaywcjlove
Copy link
Owner

@yyjjqq94 thx!

@madfriend
Copy link
Contributor

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't bind to + (plus)
5 participants