Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'scope' an optional option #95

Merged
merged 1 commit into from
Jul 14, 2019
Merged

Conversation

Smona
Copy link
Contributor

@Smona Smona commented Jul 14, 2019

First off, I'd like to thank the maintainers for the lovely little hotkey library! I ran into some difficulty when writing a Typescript wrapper for hotkeys due to the fact the scope option is required.

The documentation doesn't mention this as a required option, and in use the library works fine passing an options object without scope, so it should probably be marked as optional.

The documentation doesn't mention this as a required option, and in use the library works fine passing an options object without `scope`.
@codecov-io
Copy link

codecov-io commented Jul 14, 2019

Codecov Report

Merging #95 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #95   +/-   ##
======================================
  Coverage    83.9%   83.9%           
======================================
  Files           1       1           
  Lines         174     174           
======================================
  Hits          146     146           
  Misses         28      28

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0151be...ac2cdf3. Read the comment docs.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 156

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.942%

Totals Coverage Status
Change from base Build 154: 0.0%
Covered Lines: 146
Relevant Lines: 174

💛 - Coveralls

@jaywcjlove jaywcjlove merged commit 134075b into jaywcjlove:master Jul 14, 2019
jaywcjlove added a commit that referenced this pull request Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants