Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple arguments in the command line #146

Merged
merged 1 commit into from
Oct 29, 2020
Merged

feat: support multiple arguments in the command line #146

merged 1 commit into from
Oct 29, 2020

Conversation

vanpipy
Copy link
Contributor

@vanpipy vanpipy commented Oct 27, 2020

For closing #144

@vanpipy vanpipy marked this pull request as ready for review October 27, 2020 17:27
@jaywcjlove
Copy link
Owner

jaywcjlove commented Oct 28, 2020

@vanpipy Is gadget minimist more appropriate?

@vanpipy
Copy link
Contributor Author

vanpipy commented Oct 28, 2020

Hi @jaywcjlove , i got your idea. Because of the future of the mocker commander, try to replace the minimist of the commander. If we want to enhance the mocker commander, it will be easier to expand.

Anyway, we do not need it now :D. I will rewrite to the minimist version.

@vanpipy
Copy link
Contributor Author

vanpipy commented Oct 29, 2020

Hi, @jaywcjlove ,

I turn around again and finish it in the end!! 😆

@jaywcjlove jaywcjlove merged commit 9e52e06 into jaywcjlove:master Oct 29, 2020
@jaywcjlove
Copy link
Owner

@vanpipy Thx! Hope to improve the documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants