feat: use template engine for styles #240
Conversation
| import copy from '@tsbb/copy-template-dir'; | ||
| import { deleteAsync } from 'del'; | ||
| import { moveFile } from 'move-file'; | ||
| import nunjucks from 'nunjucks'; |
There was a problem hiding this comment.
nunjucks template library seems to have been abandoned.
| {% for idx, linkItem in links %} | ||
| <a href="{{ linkItem.url }}">{{ linkItem.title }}</a>{% if not loop.last %} · {% endif %} | ||
| {% endfor %} | ||
| {% endif %} |
There was a problem hiding this comment.
@undefined-moe The code has an issue; the loop does not generate any content.
There was a problem hiding this comment.
@undefined-moe I tried to resolve this issue but couldn't, so I've decided to roll back the code.
There was a problem hiding this comment.
Got it fixed in commit undefined-moe@3fef5e1
| @@ -2,17 +2,17 @@ | |||
| <html lang="en"> | |||
There was a problem hiding this comment.
The template should be named index.njk; this will enable code highlighting.
There was a problem hiding this comment.
renamed, do i have to create another pull request for this?
There was a problem hiding this comment.
@undefined-moe There are multiple issues; it is recommended to debug locally, for example, the icons in the HTML are not previewing.
You're welcome to submit a new PR.
This reverts commit 668989e.
@undefined-moe There are also issues with the style output. The correct SCSS output is as follows: $uiw-font-adobe: "\ea01";
$uiw-font-demo: "\ea02";
$uiw-font-git: "\ea03";
$uiw-font-left: "\ea04";
$uiw-font-stylelint: "\ea05"; |
|
check undefined-moe@47263bc |
|
Stylus use do have a working example but it's super tricky: https://github.com/hydro-dev/Hydro/blob/50f1ac92784240c8e6f8df9bc753735c426df273/packages/ui-default/build/main.ts#L119-L120 upd: And you are right, it's better to prefix variables with fontname. |
|
@undefined-moe You are right; it should use You're welcome to submit a new PR. |
As template engine have to be used to generate website, why not use it on styles to introduce more possibilities (see changes to stylus template).
Old style templates should work without any changes needed, while it's a breaking change for people depending on custom website templates as they have to rewrite to a different templating syntax.
about changes to tests:
stylesis empty folder before, no idea why it exists.further tests on builtin html template might be needed.