Handle errors when saving files gracefully #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| from StringIO import StringIO | ||
| except ImportError: | ||
| from io import StringIO |
There was a problem hiding this comment.
👍, io.StringIO doesn't have the right behavior in Python 2.7. This is very confusing.
SpotlightKid
force-pushed
the
feature/save-with-backup
branch
2 times, most recently
from
15e1554 to
9fac51a
Compare
Fixes jazzband#118. * Prevent existing files from being wiped when writing fails * Backup previous file if it exists when writing succeeds Signed-off-by: Christopher Arndt <chris@chrisarndt.de>
SpotlightKid
force-pushed
the
feature/save-with-backup
branch
from
9fac51a to
2d52135
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118.
To fix test failures with python 2.7 I had to change the imports at the top of the tests so that the test under Python 2.7 always use
StringIO.StringIOinstead ofio.StringIO. The latter doesn't cooperate withjson.dumpunder Python 2.7.