Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setup.py #175

Merged
merged 2 commits into from
Dec 9, 2017
Merged

Fix setup.py #175

merged 2 commits into from
Dec 9, 2017

Conversation

MinchinWeb
Copy link
Contributor

Tried to install the project (pip install -e .) and it broke with the following error:

'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Unordered types are not allowed

This pull request is a one-line change to return the requirements as a tuple rather than a set, and thus allow the project to install.

I'm on Python 3.6.3 on Windows 10 x64.

'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Unordered types are not allowed
@willdurand willdurand requested a review from k4nar December 9, 2017 03:23
@SpotlightKid
Copy link
Contributor

Uh, when did pip change in this manner?

@jmaupetit
Copy link
Contributor

I encountered the same behavior recently.

Copy link
Contributor

@jmaupetit jmaupetit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@jmaupetit
Copy link
Contributor

Looks like we also have to fix (or ignore) this new E722 flake8 rule.

@MinchinWeb
Copy link
Contributor Author

I could fix the flake8 error simply enough.

The remaining Travis-CI failure is Python 3.3, because pytest dropped support with version 3.3.0, released about 2 weeks ago. Should support for Python 3.3 be dropped here too? Alternately, pytest could be pinned to v3.2.5, but I don't know enough about tox to pull that off myself.

@SpotlightKid
Copy link
Contributor

Alternately, pytest could be pinned to v3.2.5, but I don't know enough about tox to pull that off myself.

Changing line 7 in tox.ini to:

    pytest<=3.2.5

should do the trick.

Unfortunately there's also a problem with arrow and Python 2.7. Arrpow release 0.11.0 and 0.12.0 have broken dependencies for Python 2.7 (backports.functools_lru_cache is not declared). So we have to also put

arrow<0.11.0

in requirements.txt for all tests to pass when running tox (without any existing virtualenv).

@SpotlightKid SpotlightKid merged commit f5760c7 into jazzband:master Dec 9, 2017
@MinchinWeb
Copy link
Contributor Author

@SpotlightKid see #180 for an alternate way of dealing with the requirement issue.

@ghost
Copy link

ghost commented Dec 28, 2017

This is preventing me from installing the AUR version, it just fails with 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Unordered types are not allowed.

Mind publishing a new release if this fixed it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants