report/log: add lunar start time options 🌔 #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's a wonderful feature 😉 Can you please fix formatting issues (see travis job output)? |
|
All 💚 |
jmaupetit
approved these changes
Jul 30, 2018
tests/test_fullmoon.py
Outdated
|
|
||
| aniceday_result = get_last_full_moon(aniceday) | ||
|
|
||
| assert aniceday_result == aniceday_lastMoon |
There was a problem hiding this comment.
Can you remove the two empty lines above?
docs/user-guide/commands.md
Outdated
| -----|----- | ||
| `-f, --from DATE` | Date and time of start of tracked activity [required] | ||
| `-t, --to DATE` | Date and time of end of tracked activity [required] | ||
| `--help` | Show this message and exit. |
There was a problem hiding this comment.
Looks like this should not be part of this PR, but was missing...
|
@jmaupetit Done. I will squash a last time before you merge. |
added 2 commits
July 30, 2018 16:38
supplying --luna (e.g. instead of --month), the last full moon will be taken as the start date of the summary. The start date of a lunar month is not fixed, some cultures use the new moon (chinese), some use the full moon (hindu) and some use the first sight of the crescent (jewish / hebrew). I implemented the full moon calendar because today is a full moon and a total lunar eclipse. My hope is to adjust my work load according the moon cycle. Peace.
|
@jmaupetit @k4nar squashed and still green |
jmaupetit
added a commit
that referenced
this pull request
Mar 25, 2019
Added: - New `add` command (#202) - Add lunar start time options to the `report` and `log` commands (#215) - Aggregate reports by day (#231) - Fish shell completion (#239) - Add support for first day of the week configuration in reports and logs (#240) - Python 3.7 support (#241) - Add `start --no-gap` and `stop --at` options (#254) Changed: - The `edit` command now checks data consistency (#203) - Current state saving is now improve when using Watson as a library (#214) - Prevent calling `get_start_time_for_period` multiple times (#219) Fixed: - Improved support for UTF-8 with Python 2 (#211) - Zsh completion for tags and projects with spaces in their names (#227) - Typos in commands output (#230, #235) - Project URL of the project in PyPI (#260) Removed: - Python 3.3 support (#210).
Merged
jmaupetit
added a commit
that referenced
this pull request
Mar 25, 2019
Added: - New `add` command (#202) - Add lunar start time options to the `report` and `log` commands (#215) - Aggregate reports by day (#231) - Fish shell completion (#239) - Add support for first day of the week configuration in reports and logs (#240) - Python 3.7 support (#241) - Add `start --no-gap` and `stop --at` options (#254) Changed: - The `edit` command now checks data consistency (#203) - Current state saving is now improve when using Watson as a library (#214) - Prevent calling `get_start_time_for_period` multiple times (#219) Fixed: - Improved support for UTF-8 with Python 2 (#211) - Zsh completion for tags and projects with spaces in their names (#227) - Typos in commands output (#230, #235) - Project URL of the project in PyPI (#260) Removed: - Python 3.3 support (#210).
jmaupetit
added a commit
that referenced
this pull request
Mar 25, 2019
Added: - New `add` command (#202) - Add lunar start time options to the `report` and `log` commands (#215) - Aggregate reports by day (#231) - Fish shell completion (#239) - Add support for first day of the week configuration in reports and logs (#240) - Python 3.7 support (#241) - Add `start --no-gap` and `stop --at` options (#254) Changed: - The `edit` command now checks data consistency (#203) - Current state saving is now improve when using Watson as a library (#214) - Prevent calling `get_start_time_for_period` multiple times (#219) Fixed: - Improved support for UTF-8 with Python 2 (#211) - Zsh completion for tags and projects with spaces in their names (#227) - Typos in commands output (#230, #235) - Project URL of the project in PyPI (#260) Removed: - Python 3.3 support (#210).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supplying --luna (e.g. instead of --month), the last full moon
will be taken as the start date of the summary.
The start date of a lunar month is not fixed, some cultures use
the new moon (chinese), some use the full moon (hindu) and some
use the first sight of the crescent (jewish / hebrew).
I implemented the full moon calendar because today is a full moon
and a total lunar eclipse.
My hope is to adjust my work load according the moon cycle.
Peace.