Add --ignore-project and --ignore-tag to report #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k4nar
reviewed
Jun 27, 2019
watson/frames.py
Outdated
| (tags is None or any(tag in frame.tags for tag in tags)) and | ||
| (ignore_tags is None | ||
| or any(tag not in frame.tags for tag in ignore_tags)) and |
There was a problem hiding this comment.
Shouldn't it be all instead of any?
k4nar
reviewed
Jun 27, 2019
Co-Authored-By: Yannick PÉROUX <yannick.peroux@gmail.com>
k4nar
reviewed
Jul 3, 2019
| @@ -443,19 +443,27 @@ def merge_report(self, frames_with_conflict): | |||
|
|
|||
| return conflicting, merging | |||
|
|
|||
| def _validate_report_options(self, filtrate, ignored): | |||
| return bool( | |||
| filtrate and ignored and set(filtrate).intersection(set(ignored))) | |||
There was a problem hiding this comment.
I think that if a function "validate" something, it should return True when it's valid, not the opposite :) .
There was a problem hiding this comment.
fair enough :P I'll take a look at it tomorrow and push a fixed version :)
k4nar
previously approved these changes
Jul 8, 2019
|
not at all, my pleasure |
* add aggregation completion * add completion profile for add * cosmetic fixes to watson.fish: - reorder ungrouped completions - add missing comment * add CSV support to aggregate, log, and report * extend existing completion profiles: - adds --luna to report and log - adds --at to stop * properly display confirm-new options
Co-Authored-By: Yannick PÉROUX <yannick.peroux@gmail.com>
jmaupetit
approved these changes
Jul 16, 2019
gnanet
added a commit
to gnanet/Watson
that referenced
this pull request
Sep 21, 2020
* Add two options to ignore a project or a tag when requesting a log, in the same way you can do it with report (see jazzband#288).
lefi7z
added a commit
to lefi7z/Watson
that referenced
this pull request
Jul 4, 2022
This reverts commit 699ccda.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two options to ignore a project or a tag when generating a report, in the same way you can select some. I've used some json formatting +
jqmagic to filter out some specific tags from things like daily standups/weekly reports but it was a bit of a monstrosity, to be honest.