Use Arrows for_json for JSON output #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrow provides a `for_json()` function encoding Arrow objects for JSON output. Using the default-parameter of `json.dumps()`, this function is invoked on Arrow objects which can then be encoded for JSON output.
Using Python 3.x, builtins have to be imported, whereas in Python 2.x they are available in the namespace
|
Sure, I added a short description to the changelog and provided some basic tests. Let me know if the tests should cover more cases, I provided ones for the two that came to my mind. |
davidag
pushed a commit
to davidag/Watson
that referenced
this pull request
Oct 16, 2019
Arrow provides a `for_json()` function encoding Arrow objects for JSON output. Using the default-parameter of `json.dumps()`, this function is invoked on Arrow objects which can then be encoded for JSON output. Reference PR: jazzband#330 Fix jazzband#329
ericguirbal
added a commit
to ericguirbal/Watson
that referenced
this pull request
Oct 19, 2019
PR jazzband#330 forgot to fix the aggregate command (see bug jazzband#329).
ericguirbal
added a commit
to ericguirbal/Watson
that referenced
this pull request
Oct 19, 2019
PR jazzband#330 forgot to fix the aggregate command (see bug jazzband#329).
ericguirbal
added a commit
to ericguirbal/Watson
that referenced
this pull request
Oct 19, 2019
PR jazzband#330 forgot to fix the aggregate command (see bug jazzband#329).
davidag
pushed a commit
to davidag/Watson
that referenced
this pull request
Oct 21, 2019
PR jazzband#330 forgot to fix the aggregate command (see bug jazzband#329). Reference PR jazzband#331
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arrow provides a
for_json()function encoding Arrow objects for JSON output.Using the default-parameter of
json.dumps(), this function is invoked on Arrow objects which can then be encoded for JSON output.This PR fixes #329