Limit arrow version to under 0.15.6 #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmaupetit
approved these changes
May 4, 2020
oxzi
added a commit
to oxzi/Watson
that referenced
this pull request
Jun 7, 2020
Since its last release[0], the heavily used arrow library supports ISO week dates[1]. The CLI tests assumed that arrow does not support this. However, the new version nullified this assumption. As a provisional measure, the version of arrow was limited upwards in PR jazzband#372[2]. An obsolete version was thereby requested. A current version, or at least support for one, is important for third-party package managers. Especially GNU/Linux distributions prefer to use their own package manager to install software over pip. Thus, this commit removes both the restriction to an outdated arrow version in the requirements.txt and validates previously invalid marked week dates. [0]:https://github.com/crsmithdev/arrow/releases/tag/0.15.6 [1]:https://en.wikipedia.org/wiki/ISO_week_date [2]:jazzband#372
oxzi
added a commit
to oxzi/Watson
that referenced
this pull request
Jun 9, 2020
Since its last release[0], the heavily used arrow library supports ISO week dates[1]. The CLI tests assumed that arrow does not support this. However, the new version nullified this assumption. As a provisional measure, the version of arrow was limited upwards in PR jazzband#372[2]. An obsolete version was thereby requested. A current version, or at least support for one, is important for third-party package managers. Especially GNU/Linux distributions prefer to use their own package manager to install software over pip. Thus, this commit removes both the restriction to an outdated arrow version in the requirements.txt and validates previously invalid marked week dates. [0]:https://github.com/crsmithdev/arrow/releases/tag/0.15.6 [1]:https://en.wikipedia.org/wiki/ISO_week_date [2]:jazzband#372
oxzi
added a commit
to oxzi/Watson
that referenced
this pull request
Jun 9, 2020
Since its last release[0], the heavily used arrow library supports ISO week dates[1]. The CLI tests assumed that arrow does not support this. However, the new version nullified this assumption. As a provisional measure, the version of arrow was limited upwards in PR jazzband#372[2]. An obsolete version was thereby requested. A current version, or at least support for one, is important for third-party package managers. Especially GNU/Linux distributions prefer to use their own package manager to install software over pip. Thus, this commit removes both the restriction to an outdated arrow version in the requirements.txt and validates previously invalid marked week dates. [0]:https://github.com/crsmithdev/arrow/releases/tag/0.15.6 [1]:https://en.wikipedia.org/wiki/ISO_week_date [2]:jazzband#372
jmaupetit
pushed a commit
that referenced
this pull request
Jun 10, 2020
Since its last release[0], the heavily used arrow library supports ISO week dates[1]. The CLI tests assumed that arrow does not support this. However, the new version nullified this assumption. As a provisional measure, the version of arrow was limited upwards in PR #372[2]. An obsolete version was thereby requested. A current version, or at least support for one, is important for third-party package managers. Especially GNU/Linux distributions prefer to use their own package manager to install software over pip. Thus, this commit removes both the restriction to an outdated arrow version in the requirements.txt and validates previously invalid marked week dates. [0]:https://github.com/crsmithdev/arrow/releases/tag/0.15.6 [1]:https://en.wikipedia.org/wiki/ISO_week_date [2]:#372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 0.15.6 of
arrowsupport iso week formats https://arrow.readthedocs.io/en/latest/releases.html. Eventually some of the docs and tests of watson could be rewritten to reflect this change, but until that is done, I suggest to pin the version ofarrowto avoid that tests fail on new PRs (and having to maintain different test cases for the different arrow versions).