Support urlencoding/decoding for hostname #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use URL Parse library for what it's good for: to decode % URL encode strings. Don't do it here -- we're already importing a better library for that!
Add synthetic test correlating to Google Cloud SQL connector socket, to make sure Issue jazzband#132 is solved.
Testing port and connector socket path together is unnecessary, possibly excessive.
|
Paging @mattseymour - this can close out nearly 4 years of open issues and PRs. |
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
==========================================
+ Coverage 86.56% 89.55% +2.98%
==========================================
Files 1 1
Lines 67 67
Branches 14 14
==========================================
+ Hits 58 60 +2
+ Misses 4 3 -1
+ Partials 5 4 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the conflicts within PR #148, and (I believe) supersedes PR #113. Issue #132 will be closed after nearly 4 years.