Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error on missing schema #196

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Conversation

palfrey
Copy link
Member

@palfrey palfrey commented Dec 13, 2022

Improves the "missing schema" error, which would improve the situation in #186

@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Merging #196 (f55ebcf) into master (1185468) will increase coverage by 0.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
+ Coverage   89.85%   90.27%   +0.42%     
==========================================
  Files           1        1              
  Lines          69       72       +3     
  Branches       15       17       +2     
==========================================
+ Hits           62       65       +3     
  Misses          3        3              
  Partials        4        4              
Impacted Files Coverage Δ
dj_database_url.py 90.27% <100.00%> (+0.42%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rtpg
Copy link

rtpg commented Dec 20, 2022

This looks good, but I would leave out the list of supported protocols that are supported. I don't think that's a blocker though.

@palfrey
Copy link
Member Author

palfrey commented Dec 20, 2022

This looks good, but I would leave out the list of supported protocols that are supported. I don't think that's a blocker though.

Without that, fixing things like #186 would need digging through the source code

@rtpg
Copy link

rtpg commented Dec 21, 2022

Or, like, the documentation... but I get what you're saying. I don't feel strongly about this!

@palfrey palfrey merged commit e47382d into jazzband:master Dec 21, 2022
@palfrey palfrey deleted the better-schema-error branch December 21, 2022 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants