Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Django 2.2 support. #370

Merged
merged 2 commits into from
May 1, 2022
Merged

Drop Django 2.2 support. #370

merged 2 commits into from
May 1, 2022

Conversation

hramezani
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Apr 5, 2022 •
edited
Loading

Codecov Report

Merging #370 (a1bdd2d) into master (8a5fa3f) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #370      +/-   ##
==========================================
- Coverage   82.81%   82.67%   -0.14%     
==========================================
  Files          20       20              
  Lines         512      508       -4     
==========================================
- Hits          424      420       -4     
  Misses         88       88
Impacted Files Coverage Δ
...g/migrations/0004_logentry_detailed_object_repr.py 100.00% <100.00%> (ø)
...ions/0005_logentry_additional_data_verbose_name.py 100.00% <100.00%> (ø)
.../migrations/0009_alter_logentry_additional_data.py 100.00% <100.00%> (ø)
auditlog/models.py 82.58% <100.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a5fa3f...a1bdd2d. Read the comment docs.

@hramezani hramezani marked this pull request as draft April 5, 2022 12:33
@hramezani hramezani force-pushed the drop_django22 branch 2 times, most recently from c4cae32 to 0693c27 Compare April 5, 2022 13:04
@hramezani hramezani marked this pull request as ready for review April 5, 2022 13:07
@hramezani hramezani requested a review from Linkid April 5, 2022 13:08
Linkid
Linkid requested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@Linkid Linkid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Django 2.2 is still supported until the end of the month (April 2022) :p. Maybe we can wait until May 2022.
(A new patch for Django 2.2 is scheduled for April 11, 2022)

.pre-commit-config.yaml
@@ -4,7 +4,7 @@ repos:
rev: 22.3.0
hooks:
- id: black
language_version: python3.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python 3.7 is the oldest supported Python version and is still supported by Django 3.2. So, I don't think it is necessary for now to update it.

Copy link
Member Author

@hramezani hramezani Apr 6, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this language_version here determines the python version to run the black on it.
As it was py38 on tox, I've changed it to python3.7
I think we can set --target-version to py37. I've update the PR with this change

CHANGELOG.md Outdated
@@ -3,6 +3,7 @@
#### Improvements
- feat: enable use of replica database (delegating the choice to `DATABASES_ROUTER`) ([#359](https://github.com/jazzband/django-auditlog/pull/359))
- Add `mask_fields` argument in `register` to mask sensitive information when logging ([#3710](https://github.com/jazzband/django-auditlog/pull/310))
- Django: Drop 2.2 support
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe precise that django_jsonfield_backport is not required anymore ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@hramezani
Copy link
Member Author

Django 2.2 is still supported until the end of the month (April 2022) :p. Maybe we can wait until May 2022. (A new patch for Django 2.2 is scheduled for April 11, 2022)

Yes, This is just for preparation. we can wait until May 2022 and then merge it.

@hramezani
Copy link
Member Author

@Linkid I think we can merge this one now and prepare a new release soon.
What do you think?

@Linkid
Copy link
Contributor

Linkid commented Apr 30, 2022 •
edited
Loading

Good idea, yes. But could you add to the changelog that django_jsonfield_backport is not required anymore, please?

@hramezani
Copy link
Member Author

Good idea, yes. But could you add to the changelog that django_jsonfield_backport is not required anymore, please?

Sorry, I forgot about it 🤦‍♂️. Done!

@Linkid Linkid merged commit 4c0bfab into jazzband:master May 1, 2022
This was referenced May 1, 2022
Closed
Closed
This was linked to issues May 1, 2022
Warnings caused by django_jsonfield_backport #356
Closed
RemovedInDjango40Warning: ugettext deprecated in django 3 and removed in django 4 #334
Closed
@Linkid
Copy link
Contributor

Linkid commented May 1, 2022

I've just closed some related issues. Thanks for this important PR!

@hramezani hramezani deleted the drop_django22 branch May 1, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linkid Linkid Linkid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@hramezani @Linkid