Conditionally disable / enable logging

[errrken]

If any receiver returns False, no logging will be made. This can be useful if logging should be conditionally enabled / disabled

Closes #589 possibly #586

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c581a6e) 94.85% compared to head (f580d30) 94.86%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
+ Coverage   94.85%   94.86%   +0.01%     
==========================================
  Files          31       31              
  Lines        1011     1013       +2     
==========================================
+ Hits          959      961       +2     
  Misses         52       52              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[hramezani]

Thanks @errrken for this patch. please:

• Add some test for it in

  django-auditlog/auditlog_tests/tests.py

  Line 2340 in c581a6e

  class SignalTests(TestCase):

• Add changelog entry in https://github.com/jazzband/django-auditlog/blob/master/CHANGELOG.md

[errrken]

Yeah I was just thinking if someone for some reason used to return False before - it will suddenly disable their logging - that’s why I reasoned it would be breaking… fre 24 nov. 2023 kl. 11:57 skrev Hasan Ramezani ***@***.***>:

…

***@***.**** commented on this pull request. ------------------------------ In CHANGELOG.md <#590 (comment)> : > @@ -2,6 +2,9 @@ ## Next Release +#### Breaking Changes I think it not a breaking change. as we are preparing django-auditlog for major release 3 and it's already in beta. ⬇️ Suggested change -#### Breaking Changes +#### Improvements — Reply to this email directly, view it on GitHub <#590 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC7QQUBSXGHYFT67ZUPDY23YGB4RZAVCNFSM6AAAAAA7YBROEGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTONBXG42DOMRVGA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[errrken]

Hi,
@aqeelat, @aleh-rymasheuski - any update on this?

Thanks

[errrken]

Thanks y'all, may I ask out of curiosity when we can expect it to be merged and when you expect 3.0 to be released?

[hramezani]

It will be released in the next beta release.
I am not sure about v3 release time

[errrken]

It will be released in the next beta release. I am not sure about v3 release time

Allright, so there will be one more beta? Any idea when that will be released?

[hramezani]

probably after we merged #592