Allow tags fix for Django 2.0 #40
Conversation
|
I think you need to make your your PR pass the tests before it can be merged, right now it's breaking compatibility with Python 2.7 |
|
I think the problem is that Django 2.0 gets installed on python 2.7? am I reading the travis results correctly? Django 2.0 is not supported on python 2.7 |
|
I believe your tests are broken for python 2.7, it has nothing to do with this PR. |
|
@jezdez can you please retrigger the tests and consider merging this pull request, it would be greatly appreciated. |
There was a problem hiding this comment.
@madisvain Please rebase on top of master and push to the branch again since the python 2.7 related issue is fixed now.
.gitignore
Outdated
| @@ -28,3 +28,5 @@ cover/ | |||
| .cache/ | |||
| htmlcov/ | |||
| coverage.xml | |||
| env/ | |||
| .vscode/ | |||
There was a problem hiding this comment.
Please remove the change to the .gitignore file since they are folder local do your computer. You can easily add it to your global gitignore instead.
|
@janezkranjc See my comment about rebasing on top of master, rerunning the tests won't be enough to fix it without the changes in master. |
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
+ Coverage 72.58% 72.74% +0.16%
==========================================
Files 9 9
Lines 434 433 -1
Branches 54 54
==========================================
Hits 315 315
+ Misses 114 113 -1
Partials 5 5
Continue to review full report at Codecov.
|
|
@jezdez should be good to go now. sorry for the late response. |
|
If #60 gets approved and merged, this issue can probably be closed. |
|
@jezdez what is your timeline about this PR? keep that great work up! |
This needs to be checked as I'm not 100% sure how the args and kwargs are meant to be rendering.