Support HTML tags for Django 2.0 #74
Open
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #74 +/- ##
==========================================
+ Coverage 72.58% 72.89% +0.31%
==========================================
Files 9 9
Lines 434 439 +5
Branches 54 54
==========================================
+ Hits 315 320 +5
Misses 114 114
Partials 5 5
Continue to review full report at Codecov.
|
|
@jezdez Is there any chance of getting a look at this? |
|
@jezdez would really love this feature |
misli
reviewed
Nov 12, 2018
There was a problem hiding this comment.
I was just thinking about to handle this in utils.display_field. It already gets allow_tags keyword argument (which defaults to True). It could use it to conditionally apply mark_safe on the return value. That would lead to less code. However, Your change may make it more obvious...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39
I took a much simpler approach to previous works on this. I simply added
mark_safeto all of the html output, and then added Django 2.0 to the testing matrix. No more, no less. 😄I've also verified the output on a local Django 2.0.x application, but have not verified on any <2.0, as I don't actually have one to work with anymore...