Fix code coverage and newly failing test

[uhurusurfa]

Fix failing tet due to change in v2.2.0 (2024-05-28) of dj-database-url which added an extra param DISABLE_SERVER_SIDE_CURSORS

Fix the codecoverage action

[uhurusurfa]

@pauloxnet - please can you create a codecov.io token for django-co0nfigurations and add as a secret to this repo please?
Current failure is:

Error: Codecov token not found. Please provide Codecov token with -t flag.
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4/dist/codecov' failed with exit code 1

I believe adding that will get us moving forward again so we can merge a bunch of pending PR's

[pauloxnet]

@pauloxnet - please can you create a codecov.io token for django-co0nfigurations and add as a secret to this repo please?

Can you provide some simple instructions to do that?
I want to fix the repo, but I don't have right now the time to do researches on how to do what you suggested.

[uhurusurfa]

@pauloxnet
This is where you get the token:
https://app.codecov.io/github/jazzband/django-configurations/config/general

... and these are the steps to add it to the repo:
https://docs.codecov.com/docs/adding-the-codecov-token

[pauloxnet]

@pauloxnet This is where you get the token: https://app.codecov.io/github/jazzband/django-configurations/config/general

... and these are the steps to add it to the repo: https://docs.codecov.com/docs/adding-the-codecov-token

@uhurusurfa thanks a lot, that helped, but following the steps I just realized that I don't have the permission to see or modify the settings of the project here in GitHub.

Maybe @jezdez or @blueyed can give me this permission, or they can do update the settings to add the Codecov token.

[uhurusurfa]

@jezdez Any possibility you might assign a 2nd person as maintainer to django-configurations to spread the load ... perhaps @pauloxnet ?

[uhurusurfa]

@matthiask @com4 @JimDabell @jayvdb @brylie @benspaulding @shanx @mbaechtold
Does anyone have permissions to add the codecov.io key to this repo please?
I have tried @jezdev via another route but unable to get any response and this project.is stalled without someone who can do the changes for us.

[pauloxnet]

Maybe we can start thinking to move the project to django-commons.

[uhurusurfa]

That would be a good option. Generally the Jazzband projects seem to be under supported with very few people having the required permissions to do key changes that are often needed.

[pauloxnet]

That would be a good option. Generally the Jazzband projects seem to be under supported with very few people having the required permissions to do key changes that are often needed.

That's exactly why django-commons has been created.

[shanx]

hey @uhurusurfa unfortunately while I do have the right to merge stuff in this repo, I also can't change the settings.

@pauloxnet I feel that jazzband was created with the same intention as django-commons so before putting in the effort to migrate things I'll try to see if @jezdez would maybe be willing to give org rights to some more people.

[pauloxnet]

@pauloxnet I feel that jazzband was created with the same intention as django-commons so before putting in the effort to migrate things I'll try to see if @jezdez would maybe be willing to give org rights to some more people.

I know that, I'm part of JazzBand because of its goal, but as Tim stayed in his article there was difficulties that convinced him to start Django Commons.

I invite you to read the article, there's also a link to Jannis's post
https://www.better-simple.com/django/2024/05/22/looking-for-help-django-commons/

[shanx]

Thanks for pointing this out. I've not been following these posts :)

[uhurusurfa]

I am wondering what went wromg with Jazzband... their statement on the Jazzband Github home page is:
It gives maintainers and contributors the ability to “play in the same band” instead of being forced into “artist” and “audience” roles.

[jezdez]

I'm not following all issues of all repos closely, please open tickets in jazzband/help next time so I can respond quicker.

• there is a token set for this repo, not sure why it's failing now, I've regenerated it and updated it in the repo
• @pauloxnet you should have had maintainer permissions, somehow this didn't happen when you were made project lead, might have been an GitHub API failure, this is now fixed and should give you permissions to edit some settings
• @uhurusurfa I'm not sure where you reached out, but I haven't seen a message from you personally, I can't say if this was a long time or last week when you opened this ticket. Remember this isn't my job etc pp

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.39%. Comparing base (ffe979b) to head (448c5ab).
Report is 9 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   89.96%   90.39%   +0.42%     
==========================================
  Files          25       25              
  Lines        1196     1197       +1     
  Branches      216      102     -114     
==========================================
+ Hits         1076     1082       +6     
  Misses         88       88              
+ Partials       32       27       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Job running - Paulo will review and merge

[uhurusurfa]

hey @uhurusurfa unfortunately while I do have the right to merge stuff in this repo, I also can't change the settings.

@pauloxnet I feel that jazzband was created with the same intention as django-commons so before putting in the effort to migrate things I'll try to see if @jezdez would maybe be willing to give org rights to some more people.

Thanks @shanx - as far as I can work out looking at teams in Jazzband, Jez is the only maintainer in Jazzband which seems like a serious single point of failure and needs addressing. The current setup does not make for feeling like anyone is "playing in the same band" and many people lose interest if everything takes forever to happen when a core settings nneds changing or someone with appropriate permissions needs to takee action but they are almost impossible to get hold of.

[pauloxnet]

@uhurusurfa thanks for fixings