-
-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for python3.7 and bring support for django3.12 #192
base: master
Are you sure you want to change the base?
Conversation
@pfouque are you okay with this change ? |
Definitely! NB: The repository will probably be transferred to django-commons at some point, but it will be transferred with access to the PyPI project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!
@ticosax do you have access to the settings of the repo? I don't but this could be it https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/managing-a-branch-protection-rule#deleting-a-branch-protection-rule |
You could try pushing an empty commit to force a new run of those checks ... It may work :) |
unfortunately I don't have access to the settings. @MRigal maybe yourself ? |
Also test against django releases 4.2 & 5.0
I rebased the branch and it's still the same. Apparently like @lorenzomorandini suggested, it is a branch protection rule. |
Also test against django releases 4.2 & 5.0
And change dependency to django-fsm-2 a maintained fork of django-fsm.