Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update django support #513

Merged
merged 4 commits into from
Dec 8, 2021
Merged

Conversation

hramezani
Copy link
Member

@hramezani hramezani commented Dec 7, 2021

Problem

  • Remove Django 3.1 from Python 3.10 env in tox.

  • Confirm support for Django 4.0

  • Add USE_TZ setting.

Solution

Explain the solution that has been implemented, and what has been changed.

Commandments

  • Write PEP8 compliant code.
  • Cover it with tests.
  • Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
  • Pay attention to backward compatibility, or if it breaks it, explain why.
  • Update documentation (if relevant).

@codecov
Copy link

codecov bot commented Dec 7, 2021

Codecov Report

Merging #513 (f39dd55) into master (fc5f8ad) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #513   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files           6        6           
  Lines         825      825           
=======================================
  Hits          785      785           
  Misses         40       40           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc5f8ad...f39dd55. Read the comment docs.

@hramezani hramezani requested a review from MRigal December 7, 2021 15:57
setup.py Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@hramezani
Copy link
Member Author

Thanks @adamchainz for your review!

Copy link
Member

@MRigal MRigal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good that we had no test or setup depending on pytz. Thanks @hramezani !

@hramezani hramezani merged commit 355d385 into jazzband:master Dec 8, 2021
@hramezani hramezani deleted the update_django_support branch December 8, 2021 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants