Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language Support - Add translations for Brazilian Portuguese #578

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

gmcrocetti
Copy link
Contributor

@gmcrocetti gmcrocetti commented Jul 21, 2023

Problem

Lack of Brazilian-Portuguese translation.

Solution

Pretty straightforward. Add translation files for pt_BR.

Commandments

  • Write PEP8 compliant code.
  • Cover it with tests.
  • Update CHANGES.rst file to describe the changes, and quote according issue with GH-<issue_number>.
  • Pay attention to backward compatibility, or if it breaks it, explain why.
  • Update documentation (if relevant).

@gmcrocetti gmcrocetti marked this pull request as ready for review July 21, 2023 01:25
@gmcrocetti gmcrocetti changed the title feat(locale): Add translations for Brazilian Portuguese Language Support - Add translations for Brazilian Portuguese Jul 21, 2023
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.01%. Comparing base (99458d6) to head (f39c975).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #578   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files           6        6           
  Lines         803      803           
=======================================
  Hits          763      763           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@foarsitter foarsitter merged commit 46fc42c into jazzband:master Mar 21, 2024
9 checks passed
@foarsitter
Copy link
Contributor

Thanks @gmcrocetti

@foarsitter foarsitter added this to the 4.5.0 milestone Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants