Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete test models #598

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

mthuurne
Copy link
Contributor

This PR removes a bunch of obsolete classes from tests/models.py. The tests that used them were removed long ago, but the test models escaped deletion, until now.

The code under test was removed in 6ae66e0, but some of the test code
remained.
The code under test was removed in fda2d39, but this model remained.
Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.57%. Comparing base (6e722b5) to head (9df3df9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #598   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files           6        6           
  Lines         773      773           
=======================================
  Hits          762      762           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mthuurne mthuurne mentioned this pull request Mar 22, 2024
@foarsitter foarsitter merged commit 87a9466 into jazzband:master Mar 22, 2024
9 checks passed
@mthuurne mthuurne deleted the remove-obsolete-test-models branch March 25, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants