Fix SoftDeletableModel.delete() forwarding positional args to superclass
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…class The `soft` argument was made keyword-only, to avoid conflicts with new positional arguments that might be added to Django. It was already conflicting with the `keep_parents` argument. The `using` argument is now passed to the superclass positionally, as otherwise it can overlap with `*args`, resulting in a `TypeError` on calls where `keep_parents` is passed positionally.
|
Perhaps it would be safer to not forward any positional arguments to the superclass at all, and forward only keyword arguments. However, that would mean deviating from the interface that Django defines. |
foarsitter
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
softargument was made keyword-only, to avoid conflicts with new positional arguments that might be added to Django. It was already conflicting with thekeep_parentsargument.This is a backward incompatible change: code that used to pass
softpositionally will require updating. Hopefully most code was either using the default (True) or was already passingsoft=Falseas a keyword argument.