-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed __unicode__() in mongonaut_tags.py. Added a unit test #80
Conversation
…ver which tests it
@@ -32,7 +32,7 @@ class NewUser(User): | |||
new_field = StringField() | |||
|
|||
def __unicode__(self): | |||
return self.email | |||
return unicode(self.first_name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changed to first_name
? It no longer matches the User
class above. I'd prefer this continue to be the email.
Also, why is this getting caste to unicode?
I've used |
@lchsk No big deal. I just noticed that was the example application. No need to change it. |
I'm cool with these changes. 👍 I'll give some others a day or so to look these over and then I'll merge it in. Thanks for the pull request. |
I think stronger support of unicode is always a good thing. I agree with @garrypolley that we shouldn't switch from email. |
@lchsk Are you currently using what is in this pull request? It's not had much activity for months. If you need it I can hit the merge button, but I'd like to see the email used as mentioned above. |
Hi |
Never feel embarrassed, thanks for the contribution! We appreciate any help we can get on open source projects. |
Removed __unicode__() in mongonaut_tags.py. Added a unit test
Solution for the problem mentioned in #79 with a unit test