Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django 2.0 support #81

Closed
7 tasks done
tony opened this issue Dec 7, 2017 · 4 comments
Closed
7 tasks done

Django 2.0 support #81

tony opened this issue Dec 7, 2017 · 4 comments

Comments

@tony
Copy link
Member

tony commented Dec 7, 2017

https://github.com/develtech/django-robots/tree/django-2.0

  • Update tox 8f5b5f6

  • Update travis 8f5b5f6

  • Drop 1.10 and below? #82 Drop 1.10 and below? 86cf942

  • b85ae48 Django 2.0 warning importing from urlresolvers #79 urlresolvers update

  • Test fix: d6acbfd

      File "/Users/me/work/python/django-robots/tests/test_utils/urls.py", line 16, in <module>
        url(r'^jsi18n/(?P<packages>\S+?)/$', django.views.i18n.javascript_catalog),  # NOQA
    AttributeError: module 'django.views.i18n' has no attribute 'javascript_catalog'
    
  • Test fix: 6a5baf7

      File "/Users/me/work/python/django-robots/tests/test_utils/urls.py", line 16, in <module>
     url(r'^admin/', include(admin.site.urls)),  # NOQA
      File "/Users/me/work/python/django-robots/.venv/lib/python3.6/site-packages/django/urls/conf.py", line 27, in include
        'provide the namespace argument to include() instead.' % len(arg)
     django.core.exceptions.ImproperlyConfigured: Passing a 3-tuple to include() is not supported. Pass a 2-tuple containing the list of patterns and app_name, and provide the namespace argument to include() instead.
    
  • ab18b86 Inside tests: Using User.is_authenticated() and User.is_anonymous() as methods rather than properties is no longer supported. source:

    ERROR: test_view_site_2 (tests.test_views.ViewTest)
    Traceback (most recent call last):
      File "/Users/me/work/python/django-robots/tests/test_views.py", line 82, in test_view_site_2
        request = self.get_request(path='/', user=AnonymousUser(), lang='en')
      File "/Users/me/work/python/django-robots/tests/base.py", line 31, in get_request
        if user.is_authenticated():
    TypeError: 'bool' object is not callable
    

    It should be valid to use it as a property in Django 1.10+ source

tony added a commit to develtech/django-robots that referenced this issue Dec 7, 2017
tony added a commit to develtech/django-robots that referenced this issue Dec 7, 2017
@tony tony mentioned this issue Dec 7, 2017
@mpasternak
Copy link

Wowwww, looks like I duplicated all the efforts. #85 Maintainers, how about some merge and/or release?

@tony tony closed this as completed Dec 11, 2017
@idlesign
Copy link

idlesign commented Apr 6, 2018

@tony Please push 3.1 to PyPI.

@tony
Copy link
Member Author

tony commented Apr 6, 2018

I don't have PyPI access.

@idlesign
Copy link

idlesign commented Apr 6, 2018

@jezdez Hi, Jannis, any chance you could push robots 3.1 to PyPI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants