Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin page History button has broken link for historical objects. #527

Open
ahmedaljawahiry opened this issue Feb 15, 2019 · 2 comments
Open
Labels
accepted Issue accepted for completion bug Issues related to confirmed bugs

Comments

@ahmedaljawahiry
Copy link

ahmedaljawahiry commented Feb 15, 2019

Bug
When viewing a historical object in the admin, the "HISTORY" button on the top right does nothing on-click.

To Reproduce

  1. Go to admin page.
  2. Click on any model.
  3. Click on an instance of the model to get to the admin form.
  4. Click the "HISTORY" button in the top right.
  5. Click on some past instance.
  6. Click the "HISTORY" button in the top right again.
  7. Nothing happens.

Expected behavior
On clicking the button, you return to the list of historical objects.

Screenshots
HTML from Chrome developer, showing an empty href:

image

Environment

  • OS: Windows 10
  • Browser (if applicable): Chrome
  • Django Simple History Version: 2.7.0
  • Django Version: 2.1.5
  • Database Version: PostgreSQL 10.4

Additional context
I'm not 100% sure if this is coming from your side or mine. Every other piece of history-functionality appears to be working - I cant see what would cause this bug.

@rossmechanic
Copy link
Collaborator

Thanks for this @ahmed1293 ! I don't think that button ever worked. It's just there by default. You're more than welcome to submit a PR removing it or making it work. Thanks!

@rossmechanic rossmechanic added bug Issues related to confirmed bugs accepted Issue accepted for completion labels Feb 15, 2019
@ahmedaljawahiry
Copy link
Author

Thanks for the response! Happy to help - will try to make time for this soon :)

trumpet2012 added a commit to trumpet2012/django-simple-history that referenced this issue Oct 4, 2024
trumpet2012 added a commit to trumpet2012/django-simple-history that referenced this issue Oct 4, 2024
trumpet2012 added a commit to trumpet2012/django-simple-history that referenced this issue Oct 4, 2024
trumpet2012 added a commit to trumpet2012/django-simple-history that referenced this issue Oct 4, 2024
tim-schilling pushed a commit to trumpet2012/django-simple-history that referenced this issue Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Issue accepted for completion bug Issues related to confirmed bugs
Projects
None yet
Development

No branches or pull requests

2 participants