-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fallback for ip optional #35
Conversation
HTTP_X_FORWARDED_FOR
1 similar comment
Hi @blodone thanks again for your effort. Could you explain why you'd want to see the working of this changed? As I've explained elsewhere:
|
i think for more then 50% of the people using this a module they need a way to get it working behind a proxy without writing own middleware to emulate REMOTE_ADDR just to supply django-user-sessions. As i explained its optional, so it does not affect security unless you enable it explicitly in the settings. |
I won't merge this PR as explained above and in the issues I linked to. The goal of this package is to provide Session objects as first-class ORM models. How the IP address is derived from the request information is out-of-scope. |
With this commit it would be optional to provide a fallback for reliable IP information.
otherwise we would get an integrity error so with the attribute error the user knows whats going wrong