Added test supporting client and testcase #7
Conversation
|
Hi @nagyv, thanks for your contribution. Allowing integrators of this package to test their stack is a great win. While the code looks good to go, I would like to ask you to also provide a unit test, so things don't fall apart in the future :). |
|
Hi @nagyv, please let me know if you experience difficulties adding unit tests. Otherwise I could have a go at adding those unit tests, if you're not able to provide them? |
|
I think completing and merging this PR and [https://github.com//pull/14] are key to this project being properly usable for us, and probably others too. If we can't run our existing (and large) test suite then we'll do what we just did: back out the change that started to use the project, then live without it. Not that that's your problem at all, of course, @Bouke :o) @nagyv Are you still using this project for anything? Either way, the PR could also do with TransactionTestCase support, too, if you are going to take this on yourself @Bouke. If you aren't, let me know and I'll see what we can do about finding some time for it. |
|
@stevejalim I also think this would be a nice feature to have. However code added to the project should be accompanied by unit tests, to make sure all functionality stays working in the future. While I don't have the time at the moment to create those unit tests, feel free to join in. 👍 |
|
Hi @nagyv, please let me know if you experience difficulties adding unit tests. Code added to the project should be accompanied by unit tests, to make sure all functionality stays working in the future. |
see the docs