Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add response message when token black listed. #800

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

amirbolouri87
Copy link

No description provided.

Comment on lines 121 to 122
serializer_data = response.data
serializer_data['Token detail'] = 'Token blacklisted'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be changed to match a descriptive message such as that in the test, Token detail should be message.

Can you send in a fix?

serializer_data['message'] = 'Token blacklisted'

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi thanks for your attention, sure as soon as possible

Copy link
Member

@50-Course 50-Course left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this patch @amirdjango, just found out the changed had been effected in a newer commit, and had revised my review 🚀

@@ -119,7 +119,7 @@ class TokenBlacklistView(TokenViewBase):
def post(self, request: Request, *args, **kwargs) -> Response:
response = super().post(request, *args, **kwargs)
serializer_data = response.data
serializer_data['Token detail'] = 'Token blacklisted'
serializer_data['message'] = 'Token blacklisted'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right! LGTM!

@50-Course
Copy link
Member

Just did a bisect on the failing pipeline, it so happen that two tests are breaking tox.

  • test_it_should_return_nothing_if_everything_ok (from tests.test_serializers.TestTokenBlacklistSerializer)
  • test_it_should_return_if_everything_ok (from tests.test_views.TestTokenBlacklistView)

Since the requirements had grown, I think we should revisit these tests

@50-Course 50-Course self-requested a review May 2, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants