Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the Null value of the OutstandingToken of the BlacklistMixin.blacklist #806

Merged
merged 1 commit into from
May 30, 2024
Merged

Fix the Null value of the OutstandingToken of the BlacklistMixin.blacklist #806

merged 1 commit into from
May 30, 2024

Conversation

JaeHyuckSa
Copy link
Member

@JaeHyuckSa JaeHyuckSa commented May 7, 2024 •
edited
Loading

I have made things!

I agree with what is registered in the issue below.

I confirmed that user_id and created_at were not registered in TokenRefreshView, and added user_id and created_at to OutstandingTokens in the BlacklistMixin.blacklist function.

Related issues

@JaeHyuckSa JaeHyuckSa changed the title Fix the None value of the OutstandingToken of the BlacklistMixin.blacklist Fix the Null value of the OutstandingToken of the BlacklistMixin.blacklist May 7, 2024
@ajay09 ajay09 self-requested a review May 27, 2024 23:09
ajay09
ajay09 approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@ajay09 ajay09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Verified the bug and the fix.
Test are working as well.
Thanks!

@ajay09 ajay09 merged commit d66d246 into jazzband:master May 30, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay09 ajay09 ajay09 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaeHyuckSa @ajay09