Merge #102

102: Errors method for validating geometry collections. r=frewsxcv a=hrfuller

Closes #101

geojson/geometry.py

@@ -53,6 +53,10 @@ def __init__(self, geometries=None, **extra):
         super(GeometryCollection, self).__init__(**extra)
         self["geometries"] = geometries or []
 
+    def errors(self):
+        errors = [geom.errors() for geom in self['geometries']]
+        return [err for err in errors if err]
+
 
 # Marker classes.
 

tests/test_validation.py

@@ -136,3 +136,26 @@ def test_valid_multipolygon(self):
                   (22, -18.11), (3.14, 23.17)]]
         multipoly = geojson.MultiPolygon([poly1, poly2, poly3])
         self.assertEqual(multipoly.is_valid, True)
+
+
+class TestValidationGeometryCollection(unittest.TestCase):
+
+    def test_invalid_geometrycollection(self):
+        point = geojson.Point((10, 20))
+        bad_poly = geojson.Polygon([[(2.38, 57.322), (23.194, -20.28),
+                                   (-120.43, 19.15), (25.44, -17.91)]])
+
+        geom_collection = geojson.GeometryCollection(
+                geometries=[point, bad_poly]
+            )
+        self.assertFalse(geom_collection.is_valid)
+
+    def test_valid_geometrycollection(self):
+        point = geojson.Point((10, 20))
+        poly = geojson.Polygon([[(2.38, 57.322), (23.194, -20.28),
+                                (-120.43, 19.15), (2.38, 57.322)]])
+
+        geom_collection = geojson.GeometryCollection(
+                geometries=[point, poly]
+            )
+        self.assertTrue(geom_collection.is_valid)