Change made to handle all real numbers as coordinates #173 #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #188 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 10 10
Lines 353 353
Branches 86 86
=======================================
Hits 335 335
Misses 11 11
Partials 7 7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Merged
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Sep 2, 2023
3.0.1 (2023-02-15) ------------------ - Add Support for Python 3.11.x minor revisions - jazzband/geojson#198 3.0.0 (2023-01-26) ------------------ - Support for Python versions 3.7-3.11 (Python 2 no longer supported) - Primary development branch renamed from `master` to `main` - Handle all real numbers as coordinates - jazzband/geojson#188 - Default precision improvements - jazzband/geojson#177 - CI improvements - jazzband/geojson#172 - jazzband/geojson#155 - utf-8 support added to `geojson.dumps()` - jazzband/geojson#165 - Polygons now constrained to bounding box - jazzband/geojson#147 - Better GeometryCollection handling in `util.coords()` - jazzband/geojson#146 - Improved point validation - jazzband/geojson#144
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made per discussion in #173. Suggestions were made to handle all real numbers as inputs, rather than the original
float, int, Decimaltypes only. While the original type-check works for a majority of cases, there are users who may try to create geojson objects from objects that are not inherited from the python base-classes listed above. A more generic solution was to type-check against the abstractNumbersclass, which has a nicely laid out hierarchy per PEP 3141.