Initialize default http client for downloader in constructor #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allowing users to pass a manually created `Http` object to the download class increases flexibility for various circumstances. The current implementation does not work when used inside an AWS Lambda as the filesystem is read-only and raises an unhandled IOError. The changes should be fully backwards compatible.
Codecov Report
@@ Coverage Diff @@
## master #61 +/- ##
==========================================
- Coverage 83.33% 83.08% -0.26%
==========================================
Files 4 4
Lines 264 266 +2
Branches 64 65 +1
==========================================
+ Hits 220 221 +1
Misses 25 25
- Partials 19 20 +1
Continue to review full report at Codecov.
|
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
Sep 25, 2019
Initialize default http client for downloader in constructor #61
capuanob
pushed a commit
to ennamarie19/icalevents
that referenced
this pull request
Mar 6, 2023
Initialize default http client for downloader in constructor
capuanob
pushed a commit
to ennamarie19/icalevents
that referenced
this pull request
Mar 6, 2023
Initialize default http client for downloader in constructor jazzband#61
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing users to pass a manually created
Httpobject to the download class increases flexibility for various circumstances.The current implementation does not work when used inside an AWS Lambda as the filesystem is read-only and raises an unhandled IOError.
The changes should be fully backwards compatible.