Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize default http client for downloader in constructor #61

Merged
1 commit merged into from
Sep 25, 2019

Conversation

pall-valmundsson
Copy link
Contributor

Allowing users to pass a manually created Http object to the download class increases flexibility for various circumstances.

The current implementation does not work when used inside an AWS Lambda as the filesystem is read-only and raises an unhandled IOError.

The changes should be fully backwards compatible.

Allowing users to pass a manually created `Http` object to the download
class increases flexibility for various circumstances.

The current implementation does not work when used inside an AWS Lambda
as the filesystem is read-only and raises an unhandled IOError.

The changes should be fully backwards compatible.
@codecov
Copy link

codecov bot commented Sep 24, 2019

Codecov Report

Merging #61 into master will decrease coverage by 0.25%.
The diff coverage is 72.72%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #61      +/-   ##
==========================================
- Coverage   83.33%   83.08%   -0.26%     
==========================================
  Files           4        4              
  Lines         264      266       +2     
  Branches       64       65       +1     
==========================================
+ Hits          220      221       +1     
  Misses         25       25              
- Partials       19       20       +1
Impacted Files Coverage Δ
icalevents/icalevents.py 89.79% <100%> (+0.21%) ⬆️
icalevents/icaldownload.py 71.79% <50%> (-1.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d614f...85d8c46. Read the comment docs.

@ghost ghost merged commit ba905c3 into jazzband:master Sep 25, 2019
ghost pushed a commit that referenced this pull request Sep 25, 2019
Initialize default http client for downloader in constructor #61
capuanob pushed a commit to ennamarie19/icalevents that referenced this pull request Mar 6, 2023
Initialize default http client for downloader in constructor
capuanob pushed a commit to ennamarie19/icalevents that referenced this pull request Mar 6, 2023
Initialize default http client for downloader in constructor jazzband#61
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant