Impliment support for categories attribute

[mhdzumair]

Moodle create icallender file with categories attribute. I highly need this attribute because, with this attribute i can check what is the module code for the event.

[codecov]

Codecov Report

Merging #75 (c35dc52) into master (ce0581e) will increase coverage by 1.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   82.82%   84.13%   +1.30%     
==========================================
  Files           4        4              
  Lines         326      334       +8     
  Branches       77       79       +2     
==========================================
+ Hits          270      281      +11     
+ Misses         31       29       -2     
+ Partials       25       24       -1     

Impacted Files	Coverage Δ
icalevents/icalparser.py	84.89% <100.00%> (+1.77%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0581e...c35dc52. Read the comment docs.

[mhdzumair]

Hey @awawa1 what are these review?

[amcappelli]

Any chance this could be merged soon? I would really like to have this feature as well.

[mhdzumair]

Any chance this could be merged soon? I would really like to have this feature as well.

I'm not sure if it is merged,
for the moment you can install my forked icalevent by
pip install git+https://github.com/mhdzumair/icalevents.git

or you can also include it to requirements.txt file entry as

git+https://github.com/mhdzumair/icalevents.git#egg=icalevents

then

pip install -r requirements.txt

[Hultner]

Any chance this could be merged soon? I would really like to have this feature as well.

The project is not actively maintained, I helped a little bit with maintenance since I used the library in the testing stack of a previous project but don’t any more haven’t got much bandwidth over to this. That said I will try to take a look at it next week and merge if it looks good. I’m not merging anything without proper tests as I don’t want the project to destabilize over time but this changed does look like it’s got some tests so I can hopefully safely merge it.

[Hultner]

Hey @awawa1 what are these review?

Looks like spam to me, deleted the comments.

[mhdzumair]

Any chance this could be merged soon? I would really like to have this feature as well.

The project is not actively maintained, I helped a little bit with maintenance since I used the library in the testing stack of a previous project but don’t any more haven’t got much bandwidth over to this. That said I will try to take a look at it next week and merge if it looks good. I’m not merging anything without proper tests as I don’t want the project to destabilize over time but this changed does look like it’s got some tests so I can hopefully safely merge it.

Thanks for consider this PR. I did what I want most. I hope you will be satisfied with my coding cheers!

[Hultner]

Looks great, and there's a proper test for the new feature. Approved :)

[Hultner]

@mhdzumair I merged your feature. We'll have to wait for @irgangla to cut a new release before we'll see it on pypi.