Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impliment support for categories attribute #75

Merged
merged 3 commits into from
Jan 19, 2021

Conversation

mhdzumair
Copy link
Contributor

Moodle create icallender file with categories attribute. I highly need this attribute because, with this attribute i can check what is the module code for the event.

@codecov
Copy link

codecov bot commented Nov 10, 2020

Codecov Report

Merging #75 (c35dc52) into master (ce0581e) will increase coverage by 1.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   82.82%   84.13%   +1.30%     
==========================================
  Files           4        4              
  Lines         326      334       +8     
  Branches       77       79       +2     
==========================================
+ Hits          270      281      +11     
+ Misses         31       29       -2     
+ Partials       25       24       -1     
Impacted Files Coverage Δ
icalevents/icalparser.py 84.89% <100.00%> (+1.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce0581e...c35dc52. Read the comment docs.

@mhdzumair
Copy link
Contributor Author

Hey @awawa1 what are these review?

@amcappelli
Copy link

Any chance this could be merged soon? I would really like to have this feature as well.

@mhdzumair
Copy link
Contributor Author

Any chance this could be merged soon? I would really like to have this feature as well.

I'm not sure if it is merged,
for the moment you can install my forked icalevent by
pip install git+https://github.com/mhdzumair/icalevents.git

or you can also include it to requirements.txt file entry as

git+https://github.com/mhdzumair/icalevents.git#egg=icalevents

then

pip install -r requirements.txt

@Hultner
Copy link
Member

Hultner commented Jan 16, 2021

Any chance this could be merged soon? I would really like to have this feature as well.

The project is not actively maintained, I helped a little bit with maintenance since I used the library in the testing stack of a previous project but don’t any more haven’t got much bandwidth over to this. That said I will try to take a look at it next week and merge if it looks good. I’m not merging anything without proper tests as I don’t want the project to destabilize over time but this changed does look like it’s got some tests so I can hopefully safely merge it.

@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@jazzband jazzband deleted a comment from awawa1 Jan 16, 2021
@Hultner
Copy link
Member

Hultner commented Jan 16, 2021

Hey @awawa1 what are these review?

Looks like spam to me, deleted the comments.

@mhdzumair
Copy link
Contributor Author

Any chance this could be merged soon? I would really like to have this feature as well.

The project is not actively maintained, I helped a little bit with maintenance since I used the library in the testing stack of a previous project but don’t any more haven’t got much bandwidth over to this. That said I will try to take a look at it next week and merge if it looks good. I’m not merging anything without proper tests as I don’t want the project to destabilize over time but this changed does look like it’s got some tests so I can hopefully safely merge it.

Thanks for consider this PR. I did what I want most. I hope you will be satisfied with my coding cheers!

Copy link
Member

@Hultner Hultner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, and there's a proper test for the new feature. Approved :)

@Hultner Hultner merged commit 89f3cf7 into jazzband:master Jan 19, 2021
@Hultner
Copy link
Member

Hultner commented Jan 19, 2021

@mhdzumair I merged your feature. We'll have to wait for @irgangla to cut a new release before we'll see it on pypi.

capuanob pushed a commit to ennamarie19/icalevents that referenced this pull request Mar 6, 2023
Impliment support for categories attribute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants