-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impliment support for categories attribute #75
Conversation
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
==========================================
+ Coverage 82.82% 84.13% +1.30%
==========================================
Files 4 4
Lines 326 334 +8
Branches 77 79 +2
==========================================
+ Hits 270 281 +11
+ Misses 31 29 -2
+ Partials 25 24 -1
Continue to review full report at Codecov.
|
Hey @awawa1 what are these review? |
Any chance this could be merged soon? I would really like to have this feature as well. |
I'm not sure if it is merged, or you can also include it to requirements.txt file entry as
then
|
The project is not actively maintained, I helped a little bit with maintenance since I used the library in the testing stack of a previous project but don’t any more haven’t got much bandwidth over to this. That said I will try to take a look at it next week and merge if it looks good. I’m not merging anything without proper tests as I don’t want the project to destabilize over time but this changed does look like it’s got some tests so I can hopefully safely merge it. |
Looks like spam to me, deleted the comments. |
Thanks for consider this PR. I did what I want most. I hope you will be satisfied with my coding cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, and there's a proper test for the new feature. Approved :)
@mhdzumair I merged your feature. We'll have to wait for @irgangla to cut a new release before we'll see it on pypi. |
Impliment support for categories attribute
Moodle create icallender file with categories attribute. I highly need this attribute because, with this attribute i can check what is the module code for the event.