-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reccuring all day events #80
Reccuring all day events #80
Conversation
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 85.04% 86.87% +1.82%
==========================================
Files 4 4
Lines 341 358 +17
Branches 81 90 +9
==========================================
+ Hits 290 311 +21
+ Misses 27 25 -2
+ Partials 24 22 -2
Continue to review full report at Codecov.
|
0da4949
to
6aa12a2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very nice, thanks for the hard work! 💯
I noted some minor things you might want to change or add comments elaborating why we're doing things we are doing.
…ezone issues in a generalized way for all reccuring events
@Hultner Can I ask you to review the changes made? |
Sorry for slow response, I were quite busy with getting things in order before vacations, and then summer happen. But I'm back at work now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Looks much simple after your second revision :)
I just commited my suggested formatting change.
Will merge when (if) CI passes.
Looks like the pipeline newer executed :/ @eigenmannmartin Should I just merge it anyway or should we wait until we’ve moved to GH-actions? |
I think we can wait for the gh actions to work :-) |
Will do :) |
Codecov Report
@@ Coverage Diff @@
## master #80 +/- ##
==========================================
+ Coverage 85.04% 87.04% +1.99%
==========================================
Files 4 4
Lines 341 355 +14
Branches 81 92 +11
==========================================
+ Hits 290 309 +19
+ Misses 27 22 -5
Partials 24 24
Continue to review full report at Codecov.
|
…ay-events Reccuring all day events
Issue: office 365 recurring all day events not working.
closes #71
closes #56
closes #54
closes #12
closes #45
includes/based on #79
Sorry for the two prs. Hope this pr holds up to your standards 😉