Add codecov, pipenv, black, pre-commit #83

eigenmannmartin · 2021-10-11T06:37:39Z

I have added the following things:

codecov
pipenv
black
pre-commit

Pre-commit was added by someone else and it makes sense I think.

Black allows us to remove any guesswork about formatting 😄

Makes repeated builds much more reliable.

codecov · 2021-10-11T06:40:36Z

Codecov Report

❗ No coverage uploaded for pull request base (master@ebe2c2c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #83   +/-   ##
=========================================
  Coverage          ?   85.04%           
=========================================
  Files             ?        4           
  Lines             ?      341           
  Branches          ?       81           
=========================================
  Hits              ?      290           
  Misses            ?       27           
  Partials          ?       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebe2c2c...adc7d67. Read the comment docs.

for more information, see https://pre-commit.ci

…/add-codecov

Hultner · 2021-10-11T18:04:25Z

Overall great initiative there's only one thing in hesitant about, which is pipenv.

Pipenv is mainly geared towards application development, I’d much rather use poetry or similar which is meant for library/package development. Shouldn’t be too hard to migrate. What do you think?

eigenmannmartin · 2021-10-11T18:07:32Z

Overall great initiative there's only one thing in hesitant about, which is pipenv.

Pipenv is mainly geared towards application development, I’d much rather use poetry or similar which is meant for library/package development. Shouldn’t be too hard to migrate. What do you think?

fair point! :-)
give me a few minutes

eigenmannmartin · 2021-10-11T18:25:00Z

I also update the readme and bumped the version in the project.toml to 0.1.26

I am also thinking about adding bandit at some point.

pyproject.toml

Hultner · 2021-10-11T18:26:03Z

I also update the readme and bumped the version in the project.toml to 0.1.26

I am also thinking about adding bandit at some point.

Bandit is nice, pyflakes would also be nice.

eigenmannmartin · 2021-10-11T18:27:00Z

I also update the readme and bumped the version in the project.toml to 0.1.26
I am also thinking about adding bandit at some point.

Bandit is nice, pyflakes would also be nice.

yes - but not in this pr :-)

Hultner · 2021-10-11T18:29:17Z

.github/workflows/python-test.yml

+          python -m pip install --upgrade pip
+          pip install poetry==1.1.11
+          poetry install
+      - name: Test with pytest


Shouldn’t we enforce all our static checks here as well? Like black formatting.

the are enforced with pre-commit. this also runs on every commit here as check

https://results.pre-commit.ci/run/github/97567602/1633976767.q9PYHLRbQ-uhhYeIZmGRXQ

Every thing we’ve got in pre-commit should be enforced in GH-Actions as well.

But it is enforced as an action - it runs as check.

Hultner · 2021-10-11T18:33:48Z

Agreed, I was just brainstorming :)

On Mon, 11 Oct 2021 at 20:27, Martin Eigenmann ***@***.***> wrote: I also update the readme and bumped the version in the project.toml to 0.1.26 I am also thinking about adding bandit at some point. Bandit is nice, pyflakes would also be nice. yes - but not in this pr :-) — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAULT2VZ462MVUM74BZBWV3UGMT75ANCNFSM5FXOY5PQ> .

-- Med vänlig hälsning Alexander Hultnér

Hultner · 2021-10-11T18:34:44Z

Is pre commit being run in CI?

On Mon, 11 Oct 2021 at 20:30, Martin Eigenmann ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .github/workflows/python-test.yml <#83 (comment)>: > - # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide - flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics - - name: Test with pytest - run: | - pytest + - uses: ***@***.*** + - name: Set up Python 3.9 + uses: ***@***.*** + with: + python-version: 3.9 + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install poetry==1.1.11 + poetry install + - name: Test with pytest the are enforced with pre-commit. this also runs on every commit here as check — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAULT2WMMQHV76QPOBBLFVTUGMUL7ANCNFSM5FXOY5PQ> .

-- Med vänlig hälsning Alexander Hultnér

eigenmannmartin · 2021-10-11T18:35:14Z

Is pre commit being run in CI?

yes :-)

It runs check locally only for files in the current commit and for everything in the cloud.

Hultner · 2021-10-11T18:35:53Z

Ohh, I’m on my phone making dinner, totally missed that!

On Mon, 11 Oct 2021 at 20:32, Martin Eigenmann ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .github/workflows/python-test.yml <#83 (comment)>: > - # exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide - flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics - - name: Test with pytest - run: | - pytest + - uses: ***@***.*** + - name: Set up Python 3.9 + uses: ***@***.*** + with: + python-version: 3.9 + - name: Install dependencies + run: | + python -m pip install --upgrade pip + pip install poetry==1.1.11 + poetry install + - name: Test with pytest But it is enforced as an action - it runs as check. [image: image] <https://user-images.githubusercontent.com/2293142/136837739-97897bca-49a7-486d-acfd-cb379d3ba918.png> — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAULT2S7OM2S6OL2LG5AWFLUGMUVNANCNFSM5FXOY5PQ> .

-- Med vänlig hälsning Alexander Hultnér

eigenmannmartin · 2021-10-17T16:02:50Z

@Hultner do you think this pr is ok like it is?

Hultner

Looks good to me 👍

This follows what was done at jazzband/icalevents#83.

Add codecov, pipenv, black, pre-commit

This follows what was done at jazzband/icalevents#83.

eigenmannmartin added 2 commits October 11, 2021 08:36

feat: add codecov task

091ce50

feat: configure coverate

5aa36f0

eigenmannmartin marked this pull request as draft October 11, 2021 06:37

fix: make it run

74b2bdc

eigenmannmartin added 2 commits October 11, 2021 09:49

feat: add black, flake config and pre-commit

5f51f18

feat: uses pipenv and version locking for dependencies

8d0d3c2

eigenmannmartin changed the title ~~Add codecov~~ Add codecov, pipenv, black Oct 11, 2021

eigenmannmartin changed the title ~~Add codecov, pipenv, black~~ Add codecov, pipenv, black, pre-commit Oct 11, 2021

eigenmannmartin and others added 8 commits October 11, 2021 10:01

doc: add hint for contribution in readme

21b9f99

ci: removes unused ci skip in pre-commit

1eda28f

[pre-commit.ci] auto fixes from pre-commit.com hooks

524a79a

for more information, see https://pre-commit.ci

deps: updates pipfile.lock

08659d8

Merge branch 'f/add-codecov' of github.com:jazzband/icalevents into f…

bcd8aa8

…/add-codecov

ci: fix all black proposals

c5f4512

ci: use pipenv to run shell

9df25ba

ci: add missing dep

ffeef91

eigenmannmartin requested a review from Hultner October 11, 2021 17:53

eigenmannmartin marked this pull request as ready for review October 11, 2021 17:53

ci: only run linting in pre-commit

ff17a9e

ci: switch to poetry

0c375b5

eigenmannmartin force-pushed the f/add-codecov branch from 6857138 to 0c375b5 Compare October 11, 2021 18:22

Hultner reviewed Oct 11, 2021

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

doc: add hultner email/

adc7d67

Hultner reviewed Oct 11, 2021

View reviewed changes

eigenmannmartin requested review from Hultner and a user October 12, 2021 21:06

Hultner approved these changes Oct 17, 2021

View reviewed changes

eigenmannmartin merged commit dd3dad6 into master Oct 17, 2021

eigenmannmartin deleted the f/add-codecov branch October 17, 2021 16:23

rtpg added a commit to jazzband/django-taggit that referenced this pull request Nov 10, 2021

Add precommit configuration

8094a69

This follows what was done at jazzband/icalevents#83.

rtpg mentioned this pull request Nov 10, 2021

Add precommit configuration jazzband/django-taggit#764

Merged

auvipy pushed a commit to jazzband/django-taggit that referenced this pull request Nov 10, 2021

Add precommit configuration

534bfe4

This follows what was done at jazzband/icalevents#83.

xi mentioned this pull request Jan 23, 2023

Dependencies pinned to outdated versions #123

Closed

capuanob pushed a commit to ennamarie19/icalevents that referenced this pull request Mar 6, 2023

Merge pull request jazzband#83 from jazzband/f/add-codecov

ae87165

Add codecov, pipenv, black, pre-commit

ipyramiddev added a commit to ipyramiddev/taggit-api-django that referenced this pull request Mar 22, 2023

Add precommit configuration

aa0d105

This follows what was done at jazzband/icalevents#83.

code-worm19 added a commit to code-worm19/taggot-api-django that referenced this pull request Jan 23, 2025

Add precommit configuration

6f5eeeb

This follows what was done at jazzband/icalevents#83.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add codecov, pipenv, black, pre-commit #83

Add codecov, pipenv, black, pre-commit #83

eigenmannmartin commented Oct 11, 2021 •

edited

Loading

codecov bot commented Oct 11, 2021 •

edited

Loading

Hultner commented Oct 11, 2021

eigenmannmartin commented Oct 11, 2021

eigenmannmartin commented Oct 11, 2021

Hultner commented Oct 11, 2021

eigenmannmartin commented Oct 11, 2021

Hultner Oct 11, 2021

eigenmannmartin Oct 11, 2021

eigenmannmartin Oct 11, 2021

Hultner Oct 11, 2021

eigenmannmartin Oct 11, 2021

Hultner commented Oct 11, 2021 via email

Hultner commented Oct 11, 2021 via email

eigenmannmartin commented Oct 11, 2021 •

edited

Loading

Hultner commented Oct 11, 2021 via email

eigenmannmartin commented Oct 17, 2021

Hultner left a comment

Add codecov, pipenv, black, pre-commit #83

Add codecov, pipenv, black, pre-commit #83

Conversation

eigenmannmartin commented Oct 11, 2021 • edited Loading

codecov bot commented Oct 11, 2021 • edited Loading

Codecov Report

Hultner commented Oct 11, 2021

eigenmannmartin commented Oct 11, 2021

eigenmannmartin commented Oct 11, 2021

Hultner commented Oct 11, 2021

eigenmannmartin commented Oct 11, 2021

Hultner Oct 11, 2021

Choose a reason for hiding this comment

eigenmannmartin Oct 11, 2021

Choose a reason for hiding this comment

eigenmannmartin Oct 11, 2021

Choose a reason for hiding this comment

Hultner Oct 11, 2021

Choose a reason for hiding this comment

eigenmannmartin Oct 11, 2021

Choose a reason for hiding this comment

Hultner commented Oct 11, 2021 via email

Hultner commented Oct 11, 2021 via email

eigenmannmartin commented Oct 11, 2021 • edited Loading

Hultner commented Oct 11, 2021 via email

eigenmannmartin commented Oct 17, 2021

Hultner left a comment

Choose a reason for hiding this comment

eigenmannmartin commented Oct 11, 2021 •

edited

Loading

codecov bot commented Oct 11, 2021 •

edited

Loading

eigenmannmartin commented Oct 11, 2021 •

edited

Loading