Fix reversion of RRULE UNTIL behavior #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 87.60% 87.00% -0.60%
==========================================
Files 4 4
Lines 355 354 -1
Branches 92 91 -1
==========================================
- Hits 311 308 -3
- Misses 21 22 +1
- Partials 23 24 +1
Continue to review full report at Codecov.
|
eigenmannmartin
approved these changes
Oct 29, 2021
| @@ -156,6 +156,21 @@ def test_events_rrule_until_all_day_google(self): | |||
| self.assertEqual(ev_2.all_day, True, "All day event") | |||
| self.assertEqual(ev_2.summary, "Busy") | |||
|
|
|||
| def test_events_rrule_until_only_date(self): | |||
Prior to 0.1.25, ics files containing events like the following worked normally. [A change](11dfa8c#diff-6659079db1c5e26c4bd075f64b432522644ff3ee3bd4264f2863bd6f69d63e72L287-R405) in the 11dfa8c caused these to break. This is an ics I'm getting from Google for my scheduled lunches :) This restores the pre-0.1.25 behavior and continues to pass all tests. ``` BEGIN:VEVENT SUMMARY:LUNCH DTSTART;TZID=America/Boise:20210929T130000 DTEND;TZID=America/Boise:20210929T135000 DTSTAMP:20211029T005456Z UID:not_sure_if_this_uid_is_secret@google.com SEQUENCE:3 RRULE:FREQ=WEEKLY;UNTIL=20211020;BYDAY=MO,TH,WE;WKST=SU EXDATE;TZID=America/Boise:20211013T130000 CREATED:20210811T153934Z DESCRIPTION: LAST-MODIFIED:20210927T184338Z LOCATION: STATUS:CONFIRMED TRANSP:OPAQUE X-APPLE-TRAVEL-ADVISORY-BEHAVIOR:AUTOMATIC BEGIN:VALARM ACKNOWLEDGED:20210830T185450Z ACTION:NONE TRIGGER;VALUE=DATE-TIME:19760401T005545Z UID:343EB08E-9C4C-4151-92D0-80B351A080B2 X-WR-ALARMUID:343EB08E-9C4C-4151-92D0-80B351A080B2 END:VALARM END:VEVENT ```
|
Should be ready to merge now @eigenmannmartin . Thanks for the heads up :) |
capuanob
pushed a commit
to ennamarie19/icalevents
that referenced
this pull request
Mar 6, 2023
Fix reversion of RRULE UNTIL behavior
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 0.1.25, ics files containing events like the following worked normally. A change in 11dfa8c caused these to break. This is an ics I'm getting from Google for my scheduled lunches :)
This restores the pre-0.1.25 behavior and continues to pass all tests.
This event fails to parse with the following error: