-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix reversion of RRULE UNTIL behavior #88
Conversation
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
- Coverage 87.60% 87.00% -0.60%
==========================================
Files 4 4
Lines 355 354 -1
Branches 92 91 -1
==========================================
- Hits 311 308 -3
- Misses 21 22 +1
- Partials 23 24 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great catch!
Thank you for your pr :-D
@@ -156,6 +156,21 @@ def test_events_rrule_until_all_day_google(self): | |||
self.assertEqual(ev_2.all_day, True, "All day event") | |||
self.assertEqual(ev_2.summary, "Busy") | |||
|
|||
def test_events_rrule_until_only_date(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome!
Prior to 0.1.25, ics files containing events like the following worked normally. [A change](11dfa8c#diff-6659079db1c5e26c4bd075f64b432522644ff3ee3bd4264f2863bd6f69d63e72L287-R405) in the 11dfa8c caused these to break. This is an ics I'm getting from Google for my scheduled lunches :) This restores the pre-0.1.25 behavior and continues to pass all tests. ``` BEGIN:VEVENT SUMMARY:LUNCH DTSTART;TZID=America/Boise:20210929T130000 DTEND;TZID=America/Boise:20210929T135000 DTSTAMP:20211029T005456Z UID:not_sure_if_this_uid_is_secret@google.com SEQUENCE:3 RRULE:FREQ=WEEKLY;UNTIL=20211020;BYDAY=MO,TH,WE;WKST=SU EXDATE;TZID=America/Boise:20211013T130000 CREATED:20210811T153934Z DESCRIPTION: LAST-MODIFIED:20210927T184338Z LOCATION: STATUS:CONFIRMED TRANSP:OPAQUE X-APPLE-TRAVEL-ADVISORY-BEHAVIOR:AUTOMATIC BEGIN:VALARM ACKNOWLEDGED:20210830T185450Z ACTION:NONE TRIGGER;VALUE=DATE-TIME:19760401T005545Z UID:343EB08E-9C4C-4151-92D0-80B351A080B2 X-WR-ALARMUID:343EB08E-9C4C-4151-92D0-80B351A080B2 END:VALARM END:VEVENT ```
Should be ready to merge now @eigenmannmartin . Thanks for the heads up :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍
Fix reversion of RRULE UNTIL behavior
Prior to 0.1.25, ics files containing events like the following worked normally. A change in 11dfa8c caused these to break. This is an ics I'm getting from Google for my scheduled lunches :)
This restores the pre-0.1.25 behavior and continues to pass all tests.
This event fails to parse with the following error: