Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Template on empty/unreadable file exception is a string, not a float #91

Merged
merged 2 commits into from
Oct 30, 2021

Conversation

RickMeasham
Copy link
Contributor

Tiny typo with an empty ICS file caused a TypeError exception on the library rather than the intended IOError on the file. Test case included because ... test everything :D

@codecov
Copy link

codecov bot commented Oct 30, 2021

Codecov Report

Merging #91 (47ade19) into master (d3656af) will increase coverage by 0.56%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #91      +/-   ##
==========================================
+ Coverage   87.04%   87.60%   +0.56%     
==========================================
  Files           4        4              
  Lines         355      355              
  Branches       92       92              
==========================================
+ Hits          309      311       +2     
+ Misses         22       21       -1     
+ Partials       24       23       -1     
Impacted Files Coverage Δ
icalevents/icaldownload.py 83.33% <100.00%> (+4.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3656af...47ade19. Read the comment docs.

@eigenmannmartin eigenmannmartin merged commit c151e7c into jazzband:master Oct 30, 2021
capuanob pushed a commit to ennamarie19/icalevents that referenced this pull request Mar 6, 2023
fix: Template on empty/unreadable file exception is a string, not a float
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants