Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize support for STATUS/URL #92

Merged
merged 3 commits into from
Nov 7, 2021
Merged

Finalize support for STATUS/URL #92

merged 3 commits into from
Nov 7, 2021

Conversation

tresni
Copy link
Contributor

@tresni tresni commented Oct 30, 2021

This adds the necessary tests for #68 and rebases on latest master.

Fixes #68

@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #92 (0edd8b9) into master (c151e7c) will increase coverage by 0.27%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   87.60%   87.87%   +0.27%     
==========================================
  Files           4        4              
  Lines         355      363       +8     
  Branches       92       94       +2     
==========================================
+ Hits          311      319       +8     
  Misses         21       21              
  Partials       23       23              
Impacted Files Coverage Δ
icalevents/icalparser.py 88.19% <100.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c151e7c...0edd8b9. Read the comment docs.

@eigenmannmartin eigenmannmartin self-requested a review November 7, 2021 16:57
Copy link
Member

@eigenmannmartin eigenmannmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@eigenmannmartin eigenmannmartin merged commit c368ad8 into jazzband:master Nov 7, 2021
@tresni tresni deleted the missing-status branch March 3, 2023 02:57
capuanob pushed a commit to ennamarie19/icalevents that referenced this pull request Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants